Alternative worker to avoid TLS connection issues to DB #1955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tech stack of django-rq seems to have issues with TLS connections getting corrupted when using `Worker` (forks/multiprocessing). The alternative is to also implement a worker based on `SimpleWorker` which does not fork and does not experience this bug. This alternative worker could be configured via the `--worker-class` option of the `rqworker`, just as the `scancodeio.worker.ScanCodeIOWorker` is currently set in the docker compose files. For reference see: aboutcode-org#1523 rq/django-rq#650 https://github.com/aboutcode-org/scancode.io/blob/a89488815cad3e1e8987c0ddc98afff147d43c2a/docker-compose.yml#L86 Signed-off-by: Robert Guetzkow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tech stack of django-rq seems to have issues with TLS connections getting corrupted when using
Worker(forks/multiprocessing). This is relevant when an external database is used. The alternative is to also implement a worker based onSimpleWorkerwhich does not fork and does not experience this bug. This alternative worker could be configured via the--worker-classoption of therqworker, just as thescancodeio.worker.ScanCodeIOWorkeris currently set in the docker compose files. For reference see:scancode.io/docker-compose.yml
Line 86 in a894888